Forked Rebalance Simulation 3d

[jribbink]

Closes: #163

Description

Converts scenario 3d to a forked simulation.

Failing test is not related to this PR
https://github.com/onflow/FlowYieldVaults/actions/runs/22596031626/job/65466138035#step:9:1299

Test Output

10:44AM INF Using fork height chainId=flow-mainnet forkBlockID=24806fa16bae3ee6f3852c41ba413319306e2f5620133dd0a0786d228201a712 forkHeight=143292255 host=access.mainnet.nodes.onflow.org:9000
10:44AM INF LOG: "[TEST] Captured Position ID from event: 5"
10:44AM INF LOG: "[TEST] YieldVault ID: 208"
10:44AM INF LOG: "\n=== PRECISION COMPARISON (Initial State) ==="
10:44AM INF LOG: "Expected Yield Tokens: 615.38461539"
10:44AM INF LOG: "Actual Yield Tokens:   615.38461537"
10:44AM INF LOG: "Difference:            -0.00000002"
10:44AM INF LOG: ""
10:44AM INF LOG: "Expected Flow Collateral Value: 1000.00000000"
10:44AM INF LOG: "Actual Flow Collateral Value:   1000.00000000"
10:44AM INF LOG: "Difference:                     -0.00000000"
10:44AM INF LOG: ""
10:44AM INF LOG: "Expected MOET Debt: 615.38461539"
10:44AM INF LOG: "Actual MOET Debt:   615.38461538"
10:44AM INF LOG: "Difference:         -0.00000001"
10:44AM INF LOG: "=========================================================\n"
10:44AM INF LOG: "\n=== FLOW PRICE \u{2192} 0.5x ==="
10:44AM INF LOG: "\n=== PRECISION COMPARISON (After Flow Price Decrease) ==="
10:44AM INF LOG: "Expected Yield Tokens: 307.69230769"
10:44AM INF LOG: "Actual Yield Tokens:   307.69230767"
10:44AM INF LOG: "Difference:            -0.00000002"
10:44AM INF LOG: ""
10:44AM INF LOG: "Expected Flow Collateral Value: 500.00000000"
10:44AM INF LOG: "Actual Flow Collateral Value:   500.00000000"
10:44AM INF LOG: "Actual Flow Collateral Amount:  1000.00000000 Flow tokens"
10:44AM INF LOG: "Difference:                     -0.00000000"
10:44AM INF LOG: ""
10:44AM INF LOG: "Expected MOET Debt: 307.69230769"
10:44AM INF LOG: "Actual MOET Debt:   307.69230769"
10:44AM INF LOG: "Difference:         -0.00000000"
10:44AM INF LOG: "=========================================================\n"
10:44AM INF LOG: "\n=== YIELD VAULT PRICE \u{2192} 1.5x ==="
10:44AM INF LOG: "\n=== PRECISION COMPARISON (After Yield Price Increase) ==="
10:44AM INF LOG: "Expected Yield Tokens: 268.24457594"
10:44AM INF LOG: "Actual Yield Tokens:   268.24457535"
10:44AM INF LOG: "Difference:            -0.00000059"
10:44AM INF LOG: ""
10:44AM INF LOG: "Expected Flow Collateral Value: 653.84615385"
10:44AM INF LOG: "Actual Flow Collateral Value:   653.84615245"
10:44AM INF LOG: "Actual Flow Collateral Amount:  1307.69230491 Flow tokens"
10:44AM INF LOG: "Difference:                     -0.00000140"
10:44AM INF LOG: ""
10:44AM INF LOG: "Expected MOET Debt: 402.36686391"
10:44AM INF LOG: "Actual MOET Debt:   402.36686304"
10:44AM INF LOG: "Difference:         -0.00000087"
10:44AM INF LOG: "=========================================================\n"
10:44AM INF LOG: "\n=== TEST COMPLETE ==="

______

For contributor use:

• Targeted PR against master branch
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the standards mentioned here.
• Updated relevant documentation
• Re-reviewed Files changed in the Github PR explorer
• Added appropriate labels

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[RZhang05]

Any experience locally with inconsistent runs? First run did not trigger rebalance, this happens with scenario 3a and 3b as well. Mainly wondering if these tests could fail in CI.

Output

flow test cadence/tests/forked_rebalance_scenario3d_test.cdc 

❗   Version warning: a new version of Flow CLI is available (v2.14.3).
   Read the installation guide for upgrade instructions: https://developers.flow.com/tools/flow-cli/install 

11:42AM INF Using fork height chainId=flow-mainnet forkBlockID=24806fa16bae3ee6f3852c41ba413319306e2f5620133dd0a0786d228201a712 forkHeight=143292255 host=access.mainnet.nodes.onflow.org:9000
11:42AM INF LOG: "[TEST] Captured Position ID from event: 5"
11:42AM INF LOG: "[TEST] YieldVault ID: 208"
11:42AM INF LOG: "\n=== PRECISION COMPARISON (Initial State) ==="
11:42AM INF LOG: "Expected Yield Tokens: 615.38461539"
11:42AM INF LOG: "Actual Yield Tokens:   615.38461537"
11:42AM INF LOG: "Difference:            -0.00000002"
11:42AM INF LOG: ""
11:42AM INF LOG: "Expected Flow Collateral Value: 1000.00000000"
11:42AM INF LOG: "Actual Flow Collateral Value:   1000.00000000"
11:42AM INF LOG: "Difference:                     -0.00000000"
11:42AM INF LOG: ""
11:42AM INF LOG: "Expected MOET Debt: 615.38461539"
11:42AM INF LOG: "Actual MOET Debt:   615.38461538"
11:42AM INF LOG: "Difference:         -0.00000001"
11:42AM INF LOG: "=========================================================\n"
11:42AM INF LOG: "\n=== FLOW PRICE \u{2192} 0.5x ==="
11:42AM INF LOG: "\n=== PRECISION COMPARISON (After Flow Price Decrease) ==="
11:42AM INF LOG: "Expected Yield Tokens: 307.69230769"
11:42AM INF LOG: "Actual Yield Tokens:   615.38461537"
11:42AM INF LOG: "Difference:            +307.69230768"
11:42AM INF LOG: ""
11:42AM INF LOG: "Expected Flow Collateral Value: 500.00000000"
11:42AM INF LOG: "Actual Flow Collateral Value:   500.00000000"
11:42AM INF LOG: "Actual Flow Collateral Amount:  1000.00000000 Flow tokens"
11:42AM INF LOG: "Difference:                     -0.00000000"
11:42AM INF LOG: ""
11:42AM INF LOG: "Expected MOET Debt: 307.69230769"
11:42AM INF LOG: "Actual MOET Debt:   615.38461538"
11:42AM INF LOG: "Difference:         +307.69230769"
11:42AM INF LOG: "=========================================================\n"

Test results: "cadence/tests/forked_rebalance_scenario3d_test.cdc"
- FAIL: test_ForkedRebalanceYieldVaultScenario3D
                Execution failed:
                        error: assertion failed: Expected yield tokens after flow price decrease to be 307.69230769 but got 615.38461537
                           --> cadence/tests/forked_rebalance_scenario3d_test.cdc:281:4

[jribbink]

Any experience locally with inconsistent runs? First run did not trigger rebalance, this happens with scenario 3a and 3b as well. Mainly wondering if these tests could fail in CI.

Output

No, I hadn't seen that, but I was able to reproduce.... very strange 🤔, the only things that I can think of that could cause this non-determinism would be randomness or a bug in the testing framework/runtime...

EDIT: Thinking about this more, it could be a race condition with timestamps in the testing framework. I.e. the Band Oracle update relies on the current timestamp. If this does not advance between updates, subsequent updates may not be reflected here.

[jribbink]

Yeah, Band Oracle was the cause - fixed in 2338365