Skip to content

Remove EPosition auth requirement from FlowALP beta cap transactions #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jordanschalm wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Remove EPosition auth requirement from FlowALP beta cap transactions #175

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
38e09c0
fix: remove EPosition entitlement from beta capability to prevent una…
claude Feb 19, 2026
31275f3
fix: remove EPosition entitlement from all transaction files
jordanschalm Feb 19, 2026
558baf8
fix: update reentrancy test to withdraw via Position instead of Pool
jordanschalm Feb 19, 2026
993ff5c
document the EPosition is internal-only
jordanschalm Feb 19, 2026
12520c7
Apply suggestions from code review
jordanschalm Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cadence/tests/transactions/flow-alp/beta/claim_and_save_beta_cap.cdc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@ import "FlowALPv0"
transaction(adminAddr: Address) {

prepare(user: auth(SaveValue, LoadValue, ClaimInboxCapability) &Account) {
let claimed: Capability<auth(FlowALPv0.EParticipant, FlowALPv0.EPosition) &FlowALPv0.Pool> =
let claimed: Capability<auth(FlowALPv0.EParticipant) &FlowALPv0.Pool> =
user.inbox.claim<
auth(FlowALPv0.EParticipant, FlowALPv0.EPosition) &FlowALPv0.Pool
auth(FlowALPv0.EParticipant) &FlowALPv0.Pool
>("FlowALPv0BetaCap", provider: adminAddr)
?? panic("No beta capability found in inbox")

if user.storage.type(at: FlowALPv0.PoolCapStoragePath) != nil {
let _ = user.storage.load<
Capability<auth(FlowALPv0.EParticipant, FlowALPv0.EPosition) &FlowALPv0.Pool>
Capability<auth(FlowALPv0.EParticipant) &FlowALPv0.Pool>
>(from: FlowALPv0.PoolCapStoragePath)
}
user.storage.save(claimed, to: FlowALPv0.PoolCapStoragePath)
Expand Down
4 changes: 2 additions & 2 deletions cadence/tests/transactions/flow-alp/beta/publish_beta_cap.cdc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ import "FlowALPv0"
transaction(grantee: Address) {

prepare(admin: auth(IssueStorageCapabilityController, PublishInboxCapability) &Account) {
let poolCap: Capability<auth(FlowALPv0.EParticipant, FlowALPv0.EPosition) &FlowALPv0.Pool> =
let poolCap: Capability<auth(FlowALPv0.EParticipant) &FlowALPv0.Pool> =
admin.capabilities.storage.issue<
auth(FlowALPv0.EParticipant, FlowALPv0.EPosition) &FlowALPv0.Pool
auth(FlowALPv0.EParticipant) &FlowALPv0.Pool
>(FlowALPv0.PoolStoragePath)

assert(poolCap.check(), message: "Failed to issue beta capability")
Expand Down
6 changes: 3 additions & 3 deletions cadence/transactions/flow-alp/beta/claim_and_save_beta_cap.cdc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@ transaction(adminAddr: Address) {
prepare(user: auth(SaveValue, LoadValue, ClaimInboxCapability) &Account) {
// Save claimed cap at the protocol-defined storage path to satisfy consumers/tests expecting this path
let capPath = FlowALPv0.PoolCapStoragePath
let claimed: Capability<auth(FlowALPv0.EParticipant, FlowALPv0.EPosition) &FlowALPv0.Pool> =
let claimed: Capability<auth(FlowALPv0.EParticipant) &FlowALPv0.Pool> =
user.inbox.claim<
auth(FlowALPv0.EParticipant, FlowALPv0.EPosition) &FlowALPv0.Pool
auth(FlowALPv0.EParticipant) &FlowALPv0.Pool
>("FlowALPv0BetaCap", provider: adminAddr)
?? panic("No beta capability found in inbox")

if user.storage.type(at: capPath) != nil {
let _ = user.storage.load<Capability<auth(FlowALPv0.EParticipant, FlowALPv0.EPosition) &FlowALPv0.Pool>>(from: capPath)
let _ = user.storage.load<Capability<auth(FlowALPv0.EParticipant) &FlowALPv0.Pool>>(from: capPath)
}
user.storage.save(claimed, to: capPath)
}
Expand Down
4 changes: 2 additions & 2 deletions cadence/transactions/flow-alp/beta/publish_beta_cap.cdc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ import "FlowALPv0"
transaction(grantee: Address) {

prepare(admin: auth(IssueStorageCapabilityController, PublishInboxCapability) &Account) {
let poolCap: Capability<auth(FlowALPv0.EParticipant, FlowALPv0.EPosition) &FlowALPv0.Pool> =
let poolCap: Capability<auth(FlowALPv0.EParticipant) &FlowALPv0.Pool> =
admin.capabilities.storage.issue<
auth(FlowALPv0.EParticipant, FlowALPv0.EPosition) &FlowALPv0.Pool
auth(FlowALPv0.EParticipant) &FlowALPv0.Pool
>(FlowALPv0.PoolStoragePath)

assert(poolCap.check(), message: "Failed to issue beta capability")
Expand Down
Loading