Multi position per user scenarios testing

.github/workflows/cadence_tests.yml

@@ -28,6 +28,10 @@ jobs:
           key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
           restore-keys: |
             ${{ runner.os }}-go-
+      - uses: actions/cache@v4
+        with:
+          path: ./imports
+          key: flow-deps-${{ hashFiles('flow.json') }}
       - name: Install Flow CLI
         env:
           FLOW_CLI_VERSION: v2.7.2

cadence/scripts/flow-alp/get_oracle_price.cdc

@@ -0,0 +1,9 @@
+import "MockOracle"
+
+access(all) fun main(tokenIdentifier: String): UFix64? {
+    let tokenType = CompositeType(tokenIdentifier)
+        ?? panic("Invalid token identifier: ".concat(tokenIdentifier))
+
+    let oracle = MockOracle.PriceOracle()
+    return oracle.price(ofToken: tokenType)
+}

cadence/tests/adversarial_recursive_withdraw_source_test.cdc

@@ -74,6 +74,7 @@ fun testRecursiveWithdrawSource() {
 
     let initialDeposit1 = 10000.0
     createPosition(
+        admin: PROTOCOL_ACCOUNT,
         signer: user1,
         amount: initialDeposit1,
         vaultStoragePath: /storage/flowTokenVault,

cadence/tests/adversarial_type_spoofing_test.cdc

@@ -42,7 +42,7 @@ fun setup() {
     setupMoetVault(hackerAccount, beFailed: false)
 
     // provide liquidity to the pool we can extract
-    createPosition(signer: liquidityAccount, amount: 10000.0, vaultStoragePath: flowVaultStoragePath, pushToDrawDownSink: false)
+    createPosition(admin: PROTOCOL_ACCOUNT, signer: liquidityAccount, amount: 10000.0, vaultStoragePath: flowVaultStoragePath, pushToDrawDownSink: false)
 }
 
 access(all)

cadence/tests/async_update_position_test.cdc

@@ -33,7 +33,7 @@ fun testUpdatePosition() {
     setupMoetVault(user, beFailed: false)
     mintFlow(to: user, amount: 1_000.0)
 
-    createPosition(signer: user, amount: 100.0, vaultStoragePath: FLOW_VAULT_STORAGE_PATH, pushToDrawDownSink: false)
+    createPosition(admin: PROTOCOL_ACCOUNT, signer: user, amount: 100.0, vaultStoragePath: FLOW_VAULT_STORAGE_PATH, pushToDrawDownSink: false)
 
     // increase price
     setMockOraclePrice(signer: PROTOCOL_ACCOUNT, forTokenIdentifier: FLOW_TOKEN_IDENTIFIER, price: initialPrice * priceIncreaseFactor)

cadence/tests/deposit_capacity_test.cdc

@@ -59,7 +59,7 @@ fun test_deposit_capacity_consumption() {
     let capacityBeforePositionCreation = capacityInfo["depositCapacity"]!
     let initialDepositAmount = 100.0
 
-    createPosition(signer: user, amount: initialDepositAmount, vaultStoragePath: MOET.VaultStoragePath, pushToDrawDownSink: false)
+    createPosition(admin: PROTOCOL_ACCOUNT, signer: user, amount: initialDepositAmount, vaultStoragePath: MOET.VaultStoragePath, pushToDrawDownSink: false)
 
     // Get capacity right after position creation - should have decreased by initialDepositAmount
     capacityInfo = getDepositCapacityInfo(vaultIdentifier: MOET_TOKEN_IDENTIFIER)
@@ -118,7 +118,7 @@ fun test_per_user_deposit_limits() {
     mintMoet(signer: PROTOCOL_ACCOUNT, to: user1.address, amount: 10000.0, beFailed: false)
 
     let initialDeposit1 = 100.0
-    createPosition(signer: user1, amount: initialDeposit1, vaultStoragePath: MOET.VaultStoragePath, pushToDrawDownSink: false)
+    createPosition(admin: PROTOCOL_ACCOUNT, signer: user1, amount: initialDeposit1, vaultStoragePath: MOET.VaultStoragePath, pushToDrawDownSink: false)
     // After position creation: usage = 100 (out of 500 limit)
 
     // User 1 deposits more (should be accepted up to limit)
@@ -140,7 +140,7 @@ fun test_per_user_deposit_limits() {
     mintMoet(signer: PROTOCOL_ACCOUNT, to: user2.address, amount: 10000.0, beFailed: false)
 
     let initialDeposit2 = 100.0
-    createPosition(signer: user2, amount: initialDeposit2, vaultStoragePath: MOET.VaultStoragePath, pushToDrawDownSink: false)
+    createPosition(admin: PROTOCOL_ACCOUNT, signer: user2, amount: initialDeposit2, vaultStoragePath: MOET.VaultStoragePath, pushToDrawDownSink: false)
     // After position creation: usage = 100 (out of 500 limit)
 
     // User 2 should be able to deposit up to their own limit (500 total, so 400 more)
@@ -197,7 +197,7 @@ fun test_capacity_regeneration() {
     let capacityBeforePositionCreation = capacityInfo["depositCapacity"]!
     let initialDepositAmount = 100.0
 
-    createPosition(signer: user, amount: initialDepositAmount, vaultStoragePath: MOET.VaultStoragePath, pushToDrawDownSink: false)
+    createPosition(admin: PROTOCOL_ACCOUNT, signer: user, amount: initialDepositAmount, vaultStoragePath: MOET.VaultStoragePath, pushToDrawDownSink: false)
 
     // Get capacity right after position creation (no regeneration should occur)
     capacityInfo = getDepositCapacityInfo(vaultIdentifier: MOET_TOKEN_IDENTIFIER)
@@ -275,7 +275,7 @@ fun test_user_usage_reset_on_regeneration() {
     mintMoet(signer: PROTOCOL_ACCOUNT, to: user.address, amount: 10000.0, beFailed: false)
 
     let initialDepositAmount = 100.0
-    createPosition(signer: user, amount: initialDepositAmount, vaultStoragePath: MOET.VaultStoragePath, pushToDrawDownSink: false)
+    createPosition(admin: PROTOCOL_ACCOUNT, signer: user, amount: initialDepositAmount, vaultStoragePath: MOET.VaultStoragePath, pushToDrawDownSink: false)
     // After position creation: usage = 100 (out of 500 limit)
 
     // User deposits more to reach their limit (500 total, so 400 more)
@@ -346,7 +346,7 @@ fun test_multiple_hours_regeneration() {
     mintMoet(signer: PROTOCOL_ACCOUNT, to: user.address, amount: 1000.0, beFailed: false)
 
     let initialDepositAmount = 100.0
-    createPosition(signer: user, amount: initialDepositAmount, vaultStoragePath: MOET.VaultStoragePath, pushToDrawDownSink: false)
+    createPosition(admin: PROTOCOL_ACCOUNT, signer: user, amount: initialDepositAmount, vaultStoragePath: MOET.VaultStoragePath, pushToDrawDownSink: false)
     // The initial deposit consumes capacity, but we're checking the cap regeneration, not capacity
 
     // Make a small deposit to trigger regeneration