feat: Terminate Workflow action will still execute exitHandler tasks #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Specifically, if a sidecar is labeled with "sys-tensorboard-like", code attempts to create services and virtual services (routes). - Code will create argo templates that are resource type, where the manifests are the generated resources. The templates are then added right before the template with the sidecar that requires these services and routes.
and dependencies to the entry point template. - Issue: Argo throws this error Message: invalid spec: templates.main.tasks.train-model.dependencies[1] dependency 'k8s-service-resource' not defined
- Otherwise, the step hangs and never finishes, so long as istio container runs.
If Tensorboard has 6006 set, we also set it to 6006.
- workflow.name is assigned at run-time, and may not be DNS compliant for a service name. So that variable is not used.
- Check if tty is set to true on the sidecar. - Updated formatting.
workflow is finished. - Adding clean-up code to run alongside any onExit tasks.
- For multiple sidecars, this needs to be unique as well.
it's own function.
The new structure is: sys-send-status -> service -> virtual service -> main task If there are multiple sidecars for the same template, they are displayed next to each other, vertically and in parallel.
- The clean up tasks for service(s) and virtualservice(s) will now display vertically. If multiple sidecars were present, parallel vertical rows will display.
- These are the URLs for the side-cars.
- sys-exit will run after deletion of service and virtual service
- This ensures that multiple sidecars will vertically end at the sys-exit task.
sidecars. - This way, sidecars have access
Contributor
Author
|
This also includes changes in #691, and should be merged after. Also it seems like it is marking the Workflows as failed in the UI instead of terminated. |
aleksandrmelnikov
requested changes
Nov 12, 2020
Contributor
aleksandrmelnikov
left a comment
aleksandrmelnikov
left a comment
There was a problem hiding this comment.
Also, codacy is reporting a possible issue? I'm not seeing what the issue is though.
aleksandrmelnikov
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Using Argo stop command instead of terminate allows the Workflow to still execute exitHandler tasks.
Which issue(s) this PR fixes:
Fixes onepanelio/core#
Special notes for your reviewer:
Checklist
Please check if applies
Required