Skip to content

Conversation

@rushtehrani
Copy link
Contributor

@rushtehrani rushtehrani commented Dec 23, 2020

What this PR does:

  • Removes Filtering and pagination from Dashboard
  • Workspace buttons show/hide depending on permissions

Which issue(s) this PR fixes:

Fixes onepanelio/core#

Special notes for your reviewer:
This is the roles to test this with:

apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  name: onepanel-cluster-readonly
rules:
- apiGroups:
  - ''
  resources: ["namespaces"]
  verbs: ["get", "list"]
---
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
  name: onepanel-namespace-readonly
rules:
- apiGroups: [""]
  resources: ["services", "configmaps", "pods", "pods/log"]
  verbs: ["get", "watch", "list"]
- apiGroups: [""]
  resources: ["namespaces", "secrets"]
  verbs: ["get", "watch", "list"]
- apiGroups: ["argoproj.io"]
  resources: ["workflows", "workflowtemplates", "cronworkflows"]
  verbs: ["get", "watch", "list"]
- apiGroups: ["onepanel.io"]
  resources: ["workspaces", "workspacetemplates"]
  verbs: ["get", "watch", "list"]

Checklist

Please check if applies

  • I have added/updated relevant unit tests
  • I have added/updated relevant documentation

Required

  • I accept to release these changes under the Apache 2.0 License

@rushtehrani rushtehrani changed the title feat: Hide/show actions based on permissions feat: Dashboard and Workspace permission updates Dec 29, 2020
@rushtehrani rushtehrani marked this pull request as ready for review December 29, 2020 18:28
@Vafilor Vafilor added this to the 0.17.0 milestone Dec 29, 2020
@Vafilor Vafilor merged commit 6fd2a5f into onepanelio:master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants