Skip to content

Conversation

@Vafilor
Copy link
Contributor

@Vafilor Vafilor commented Nov 13, 2020

What this PR does:

Fixes overflow issues where the "View" button on workflow and workspaces lists would overflow to the next line on certain screen sizes. This is for both the dashboard and the individual listing pages.

This also fixes an issue where the selected namespace section of the navbar would not be flush with the bottom on bigger screen heights.

Which issue(s) this PR fixes:

Fixes onepanelio/onepanel#717

Special notes for your reviewer:

You can test this by using chrome's device toolbar and making it have more/less width. Before this fix the "View" button would overflow on certain widths.

Checklist

Please check if applies

  • I have added/updated relevant unit tests
  • I have added/updated relevant documentation

Required

  • I accept to release these changes under the Apache 2.0 License

@Vafilor Vafilor added the kind/bug Something isn't working label Nov 13, 2020
@Vafilor Vafilor added this to the v0.16.0 milestone Nov 13, 2020
@Vafilor Vafilor self-assigned this Nov 13, 2020
@rushtehrani rushtehrani merged commit 3375b80 into onepanelio:master Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

overflow of actions on workflow dashboards

2 participants