Skip to content

Conversation

@Vafilor
Copy link
Contributor

@Vafilor Vafilor commented Jun 3, 2020

What type of PR is this?

/kind bug

What this PR does:

Fixes an issue where a Confirmation Dialog appears when you edit an existing Workflow Template or save a newly created Workflow Template.

Which issue(s) this PR fixes:

Fixes onepanelio/onepanel#319

Special notes for your reviewer:

To reproduce the issue in other branches

Creating a Workflow Template

If you select a template, make sure to modify it. Otherwise, the system doesn't see any modifications so lets you save without a dialog.

Editing a Workflow Template

Make sure to modify the template then hit save.

@Vafilor Vafilor added the kind/bug Something isn't working label Jun 3, 2020
@Vafilor Vafilor added this to the v0.10.0 milestone Jun 3, 2020
@rushtehrani rushtehrani merged commit d419a1b into dev Jun 4, 2020
@rushtehrani rushtehrani deleted the fix/onepanelio.core.319-save.confirmation.dialog branch June 4, 2020 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants