Skip to content

feat: rename dev to latest #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vafilor merged 2 commits into from
Jan 12, 2021
Merged

feat: rename dev to latest #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
247ca4c
feat: rename dev to latest
Vafilor Jan 11, 2021
2b67227
fix: adjust core image to "latest" when using "Latest" flag.
Vafilor Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/apply.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ var applyCmd = &cobra.Command{

func init() {
rootCmd.AddCommand(applyCmd)
applyCmd.Flags().BoolVarP(&Dev, "dev", "", false, "Sets conditions to allow development testing.")
applyCmd.Flags().BoolVarP(&Dev, "latest", "", false, "Sets conditions to allow development/latest testing.")
}

func getPodInfo(podName string, podNamespace string) (res string, errMessage string, err error) {
Expand Down
4 changes: 2 additions & 2 deletions cmd/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,9 @@ func GenerateKustomizeResult(config opConfig.Config, kustomizeTemplate template.
coreUiImageTag := opConfig.CoreUIImageTag
coreUiImagePullPolicy := "IfNotPresent"
if Dev {
coreImageTag = "dev"
coreImageTag = "latest"
coreImagePullPolicy = "Always"
coreUiImageTag = "dev"
coreUiImageTag = "latest"
coreUiImagePullPolicy = "Always"
}
yamlFile.PutWithSeparator("applicationCoreImageTag", coreImageTag, ".")
Expand Down