Skip to content

feat: cli delete command #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 23, 2020
Merged

feat: cli delete command #87

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2b32805
feat: added basic delete command
Vafilor Nov 26, 2020
50dc739
fix: wording in error message
Vafilor Nov 26, 2020
1b65a1a
feat: added basic delete command
Vafilor Nov 26, 2020
a86adca
fix: wording in error message
Vafilor Nov 26, 2020
5e47895
Merge branch 'feat/onepanel.delete' of github.com:onepanelio/cli into…
Vafilor Dec 4, 2020
424b927
fix: added <namespace> (default value) to the list of not-allowed nam…
Vafilor Dec 4, 2020
da2c3b1
update: don't allow deleting default namespace, but do allow it in `a…
Vafilor Dec 4, 2020
ff67412
add default to reserved ns list
rushtehrani Dec 5, 2020
fe77f35
fix: edge case where no namespace was set when trying to delete
Vafilor Dec 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions util/status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ func DeploymentStatus(yamlFile *DynamicYaml) (ready bool, err error) {
namespacesToCheck["application-system"] = true
namespacesToCheck["onepanel"] = true
namespacesToCheck["istio-system"] = true
namespacesToCheck["default"] = true
Copy link
Contributor

@rushtehrani rushtehrani Dec 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vafilor added default to reserved ns list here


if yamlFile.HasKey("certManager") {
namespacesToCheck["cert-manager"] = true
Expand Down