Skip to content

Conversation

@Vafilor
Copy link
Contributor

@Vafilor Vafilor commented Nov 5, 2020

What this PR does:

Adds the init command used to be output in params.yaml.

Sample:

# - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
# Init command: opctl init --provider aks --enable-https --enable-cert-manager --dns-provider route53 --artifact-repository-provider=s3 --gpu-device-plugins nvidia
# - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
# Component: Onepanel
# Description: Onepanel application information
# - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
application:...

Which issue(s) this PR fixes:

Fixes onepanelio/onepanel#666

Special notes for your reviewer:

@Vafilor Vafilor added this to the v0.15.0 milestone Nov 5, 2020
@Vafilor
Copy link
Contributor Author

Vafilor commented Nov 5, 2020

@rushtehrani What do you think of the format?

@rushtehrani
Copy link
Contributor

@Vafilor Overall it looks great, suggestion for formatting changes:

# - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
# Generated with Onepanel CLI
# Command: opctl init --provider aks --enable-https --enable-cert-manager --dns-provider route53 --artifact-repository-provider=s3 --gpu-device-plugins nvidia
# - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

# - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
# Component: Onepanel
# Description: Onepanel application information
# - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
application:...

@Vafilor
Copy link
Contributor Author

Vafilor commented Nov 5, 2020

@rushtehrani It's committed.

@rushtehrani rushtehrani merged commit 5da834e into master Nov 5, 2020
@rushtehrani rushtehrani deleted the feat/onepanelio.core.666-init.command.in.params branch November 5, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI - Inject the command used to generate params.yaml as a comment at the top of the params.yaml file.

3 participants