Skip to content

chore: rename model serving flag #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2021
Merged

chore: rename model serving flag #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
384f6a8
fix: rename serving flag to indicate it is for model serving in general
Vafilor Aug 5, 2021
d0d5873
fix: update cli to print sys-storage url on microk8s
Vafilor Aug 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cmd/init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ var (
EnableHTTPS bool
EnableCertManager bool
EnableMetalLb bool
EnableKFServing bool
DisableServing bool
Database bool
GPUDevicePlugins []string
Services []string
Expand Down Expand Up @@ -211,7 +211,7 @@ var initCmd = &cobra.Command{
}
}

if EnableKFServing {
if !DisableServing {
if err := bld.AddComponent("kfserving"); err != nil {
log.Printf("[error] Adding component kfserving %v", err.Error())
return
Expand Down Expand Up @@ -347,7 +347,7 @@ func init() {
initCmd.Flags().StringSliceVarP(&GPUDevicePlugins, "gpu-device-plugins", "", nil, "Install NVIDIA and/or AMD gpu device plugins. Valid values can be comma separated and are: amd, nvidia")
initCmd.Flags().StringSliceVarP(&Services, "services", "", nil, "Install additional services. Valid values can be comma separated and are: modeldb")
initCmd.Flags().BoolVarP(&Database, "database", "", false, "Use a pre-existing database, set up configuration in params.yaml")
initCmd.Flags().BoolVarP(&EnableKFServing, "enable-kfserving", "", false, "Enable KFServing and Knative")
initCmd.Flags().BoolVarP(&DisableServing, "disable-serving", "", false, "Disable model serving")
}

func validateInput() error {
Expand Down
13 changes: 12 additions & 1 deletion util/kubectl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,18 @@ func PrintClusterNetworkInformation(c *kubernetes.Clientset, url string) {
}

dnsRecordMessage = "local"
fmt.Printf("\nIn your %v file, add %v and point it to %v\n", hostsPath, clusterIP, fqdn)
fmt.Printf("\nIn your %v file, add\n", hostsPath)
fmt.Printf(" %v %v\n", clusterIP, fqdn)

if config.Spec.HasLikeComponent("kfserving") {
domain := yamlFile.GetValue("application.domain").Value
defaultNamespace := yamlFile.GetValue("application.defaultNamespace").Value
modelServingURL := fmt.Sprintf("sys-storage-%v.%v", defaultNamespace, domain)

fmt.Printf(" %v %v\n", clusterIP, modelServingURL)
}

fmt.Println()
} else {
dnsRecordMessage = "an A"
if !IsIpv4(clusterIP) {
Expand Down