Move AR archive extractor from 7zip to unar. #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Wouldn't we need this switch?
|
qkaiser
force-pushed
the
358-fix-ar-extraction
branch
from
667e139 to
23e58b8
Compare
Contributor
Author
Definitely makes things simpler in the output tree :) Added. I'll open another merge request where I use this switch for rar, stuffit, and arc. |
7-zip made the conscious decision of hiding information from debian archives (.deb, ar format). See: - https://sourceforge.net/p/sevenzip/bugs/1472/ - https://sourceforge.net/p/sevenzip/bugs/1130/ In order to be complete in our extraction process, we moved to unar to extract ar archive as it won't be hiding files and extract the whole archive. Integration tests have been adjusted to reflect new output names due to our move to unar.
qkaiser
force-pushed
the
358-fix-ar-extraction
branch
from
23e58b8 to
e34287e
Compare
vlaci
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7-zip made the conscious decision of hiding information from debian archives (.deb, ar format).
See:
In order to be complete in our extraction process, we moved to unar to extract ar archive as it won't be hiding files and extract the whole archive.
Integration tests have been adjusted to reflect new output names due to our move to unar.