-
Notifications
You must be signed in to change notification settings - Fork 124
[HIP] Re add extended deleters #943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this might change the results of the If this makes a test pass which previously failed, then we'd need to update the expected output from this test executable. |
|
@kbenzie I'm not sure if all these pending reviewers are necessary. In intel/llvm just one person on the reviewers list used to get assigned to each PR. |
Correct, they are not required but they were still requested. I think I did this prior to the codeowner teams being properly setup so requested the individuals in the team. |
|
intel/llvm#11344 checks all need to pass before we can merge according to the Adapter Change Process though. |
|
@kbenzie checks passed here intel/llvm#11344 . Think should be OK to merge |
Adapter-specific change from intel/llvm#11344 .