Skip to content

Conversation

@hdelan
Copy link
Contributor

@hdelan hdelan commented Oct 10, 2023

Adapter-specific change from intel/llvm#11344 .

@kbenzie
Copy link
Contributor

kbenzie commented Oct 10, 2023

Looks like this might change the results of the test-context CTS test. Would that be expected?

 5/14 Test #13: context-adapter_hip ..............***Failed    0.45 sec
-- Found Python3: /usr/bin/python3.10 (found version "3.10.12") found components: Interpreter 
End of input file or empty file.
expected: urContextSetExtendedDeleterTest.Success/AMD_HIP_BACKEND___{{.*}}_
CMake Error at /home/test-user/actions-runner/_work/unified-runtime/unified-runtime/cmake/match.cmake:74 (message):
  Failed (1): The output of test command '/usr/bin/python3.10
  /home/test-user/actions-runner/_work/unified-runtime/unified-runtime/test/conformance/cts_exe.py;--test_command;/home/test-user/actions-runner/_work/unified-runtime/unified-runtime/build/bin/test-context'
  (stored in
  /home/test-user/actions-runner/_work/unified-runtime/unified-runtime/build/test/conformance/context/_matchtmpfile)
  does not match
  '/home/test-user/actions-runner/_work/unified-runtime/unified-runtime/test/conformance/context/context_adapter_hip.match'

If this makes a test pass which previously failed, then we'd need to update the expected output from this test executable.

@hdelan hdelan requested a review from a team as a code owner October 12, 2023 10:16
@hdelan
Copy link
Contributor Author

hdelan commented Oct 13, 2023

@kbenzie I'm not sure if all these pending reviewers are necessary. In intel/llvm just one person on the reviewers list used to get assigned to each PR.

@kbenzie
Copy link
Contributor

kbenzie commented Oct 13, 2023

@kbenzie I'm not sure if all these pending reviewers are necessary. In intel/llvm just one person on the reviewers list used to get assigned to each PR.

Correct, they are not required but they were still requested. I think I did this prior to the codeowner teams being properly setup so requested the individuals in the team.

@kbenzie
Copy link
Contributor

kbenzie commented Oct 13, 2023

intel/llvm#11344 checks all need to pass before we can merge according to the Adapter Change Process though.

@hdelan
Copy link
Contributor Author

hdelan commented Oct 13, 2023

@kbenzie checks passed here intel/llvm#11344 . Think should be OK to merge

@hdelan hdelan requested a review from a team as a code owner October 16, 2023 10:52
@kbenzie kbenzie merged commit f0de2f4 into oneapi-src:adapters Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants