Skip to content

[L0] Return success on enable/disable p2p. #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kbenzie merged 3 commits into from
Jul 8, 2024
Merged

[L0] Return success on enable/disable p2p. #1786

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18b0fdb
Return success on enable/disable p2p.
JackAKirk Jun 25, 2024
2178c35
Added hip/l0 p2p ext string.
JackAKirk Jun 25, 2024
06ab0e2
Merge branch 'main' into l0-fix-enable-p2p
JackAKirk Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions source/adapters/hip/device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(ur_device_handle_t hDevice,
// native asserts are in progress
std::string SupportedExtensions = "";
SupportedExtensions += "pi_ext_intel_devicelib_assert ";
SupportedExtensions += "ur_exp_usm_p2p ";

int RuntimeVersion = 0;
UR_CHECK_ERROR(hipRuntimeGetVersion(&RuntimeVersion));
Expand Down
1 change: 1 addition & 0 deletions source/adapters/level_zero/device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,7 @@ UR_APIEXPORT ur_result_t UR_APICALL urDeviceGetInfo(
SupportedExtensions += ("ur_exp_command_buffer ");
// Return supported for the UR multi-device compile experimental feature
SupportedExtensions += ("ur_exp_multi_device_compile ");
SupportedExtensions += ("ur_exp_usm_p2p ");

return ReturnValue(SupportedExtensions.c_str());
}
Expand Down
10 changes: 4 additions & 6 deletions source/adapters/level_zero/usm_p2p.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,8 @@ UR_APIEXPORT ur_result_t UR_APICALL urUsmP2PEnablePeerAccessExp(
std::ignore = commandDevice;
std::ignore = peerDevice;

logger::error(logger::LegacyMessage("[UR][L0] {} function not implemented!"),
"{} function not implemented!", __FUNCTION__);
return UR_RESULT_ERROR_UNSUPPORTED_FEATURE;
// L0 has peer devices enabled by default
return UR_RESULT_SUCCESS;
}

UR_APIEXPORT ur_result_t UR_APICALL urUsmP2PDisablePeerAccessExp(
Expand All @@ -28,9 +27,8 @@ UR_APIEXPORT ur_result_t UR_APICALL urUsmP2PDisablePeerAccessExp(
std::ignore = commandDevice;
std::ignore = peerDevice;

logger::error(logger::LegacyMessage("[UR][L0] {} function not implemented!"),
"{} function not implemented!", __FUNCTION__);
return UR_RESULT_ERROR_UNSUPPORTED_FEATURE;
// L0 has peer devices enabled by default
return UR_RESULT_SUCCESS;
}

UR_APIEXPORT ur_result_t UR_APICALL urUsmP2PPeerAccessGetInfoExp(
Expand Down