Skip to content

[UR][L0] Add support for urAdapterGetLastError in L0 #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kbenzie merged 1 commit into from
Nov 8, 2023
Merged

[UR][L0] Add support for urAdapterGetLastError in L0 #1033

kbenzie merged 1 commit into from
Nov 8, 2023

Conversation

@jandres742
Copy link

@jandres742 jandres742 commented Nov 2, 2023 •
edited
Loading

LLVM testing in intel/llvm#11760

@jandres742
Copy link
Author

jandres742 commented Nov 2, 2023 •
edited
Loading

this fixes an error in CTS test-runtime:

before:

[ RUN      ] urAdapterGetLastErrorTest.Success
/home/test/conformance/runtime/urAdapterGetLastError.cpp:19: Failure
Expected equality of these values:
  uur::Result(UR_RESULT_SUCCESS)
    Which is: UR_RESULT_SUCCESS
  uur::Result(urAdapterGetLastError(adapters[0], &message, &error))
    Which is: UR_RESULT_ERROR_UNSUPPORTED_FEATURE

...

[==========] 29 tests from 9 test suites ran. (3 ms total)
[  PASSED  ] 28 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] urAdapterGetLastErrorTest.Success

after:

[----------] 4 tests from urAdapterGetLastErrorTest
[ RUN      ] urAdapterGetLastErrorTest.Success
[       OK ] urAdapterGetLastErrorTest.Success (0 ms)

...
[==========] 29 tests from 9 test suites ran. (4 ms total)
[  PASSED  ] 29 tests

@jandres742 jandres742 mentioned this pull request Nov 2, 2023
Closed
@jandres742 jandres742 force-pushed the getlasterror branch 5 times, most recently from 176fb77 to 143a2e4 Compare November 3, 2023 02:42
@jandres742 jandres742 marked this pull request as ready for review November 3, 2023 03:45
@jandres742 jandres742 requested review from a team as code owners November 3, 2023 03:45
@jandres742
Copy link
Author

jandres742 commented Nov 3, 2023

@callumfare , @kbenzie : could you take a look?

kbenzie
kbenzie approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we will merge this once a couple other PR's are in, there's a small backlog we're hoping to clear soon.

@kbenzie kbenzie added the ready to merge Added to PR's which are ready to merge label Nov 3, 2023
@kbenzie
Copy link
Contributor

kbenzie commented Nov 8, 2023

I've opened intel/llvm#11811 combing this with #1028 and #1022 to merge into intel/llvm at the same time to accelerate merging.

This was referenced Nov 8, 2023
Merged
Merged
@kbenzie kbenzie merged commit ba27855 into oneapi-src:adapters Nov 8, 2023
@kbenzie kbenzie mentioned this pull request Nov 8, 2023
Merged
againull pushed a commit to intel/llvm that referenced this pull request Nov 8, 2023
@kbenzie
[UR] Bump to ec7982b (#11811)
5cdc096 
Combines the following L0 changes:

* oneapi-src/unified-runtime#1033
* oneapi-src/unified-runtime#1028
* oneapi-src/unified-runtime#1022
kbenzie added a commit to kbenzie/unified-runtime that referenced this pull request Nov 9, 2023
@kbenzie
Revert "Merge pull request oneapi-src#1033 from jandres742/getlasterror"
6b486ca 
This reverts commit ba27855, reversing
changes made to d70bae4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pbalcer pbalcer pbalcer approved these changes

+1 more reviewer

@kbenzie kbenzie kbenzie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready to merge Added to PR's which are ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jandres742 @kbenzie @pbalcer