Yii2 fix #86
Open
Yii2 fix #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added command helper feedback.
Add a Gitter chat badge to README.md
Owner
|
Hello it is good news!) As i think will be better if will be ability to choose between https and not, it can be done via few configuration changes, because now keys are hardcoded instead of that we can pass it throught configuration. I can send you worked version with https support? after you made changes related to https i can merge it! Great work! |
Author
|
Sure, sounds good! Actually i did those changes but in another machine and didn't commit changes. As far as i can remember, just changed 'http://' to '//' so it wouldn't matter what protocol developes use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long ago i made some changes so i could use it with Yii2.
Changed the bare minimum to get it working.
Classes names and namespaces mostly.