docs: add info on opening an issue when an instance fails to stop#62
Merged
dwhswenson merged 2 commits intoomsf:mainfrom Dec 4, 2025
Merged
docs: add info on opening an issue when an instance fails to stop#62dwhswenson merged 2 commits intoomsf:mainfrom
dwhswenson merged 2 commits intoomsf:mainfrom
Conversation
ethanholz
requested review from
dwhswenson
and removed request for
dwhswenson
dwhswenson
requested changes
Dec 4, 2025
Member
dwhswenson
left a comment
dwhswenson
left a comment
There was a problem hiding this comment.
One small change, otherwise looks good!
docs/aws.md
Outdated
| env: | ||
| GH_PAT: ${{ secrets.GH_PAT }} | ||
| notify_failure: | ||
| needs: [inference-test] |
Member
There was a problem hiding this comment.
inference-test isn't right here... self-hosted-test?
Contributor
Author
There was a problem hiding this comment.
That is correct. Reused from a previous example so I can add this.
Contributor
Author
|
@dwhswenson I got this fixed up. Are we good to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This address some issues we ran into where a docker failure occurs on the stop step. This should help us capture a failure if it occurs. While initially, there was discussion of a watchdog being built, I think this should work well and highlights a potential for more customization than a custom solution.