Finishing #86 #92
Merged
Finishing #86 #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling c9f12bc on peteruithoven:fix-unit-tests into * on omnidan:master*. |
|
Changes Unknown when pulling b68d07f on peteruithoven:fix-unit-tests into * on omnidan:master*. |
|
I'm ready for feedback. |
test/index.spec.js
Outdated
| expect(decrementedState.future).to.deep.equal(mockInitialState.future) | ||
| const excludedAction = { type: testConfig.FOR_TEST_ONLY_excludedActions[0] } | ||
| const notFilteredReducer = undoable(countReducer, { ...testConfig, filter: null }) | ||
| let expected = notFilteredReducer(mockInitialState, excludedAction) |
There was a problem hiding this comment.
small detail, but you can do:
{
...notFilteredReducer(mockInitialState, excludedAction),
wasFiltered: true
}
|
Changes Unknown when pulling b97d745 on peteruithoven:fix-unit-tests into * on omnidan:master*. |
| // because the action might have been was filtered it won't be added to the future | ||
| if (testConfig && !testConfig.FOR_TEST_ONLY_includeActions) { | ||
| if (incrementedState.past.length > jumpToPastIndex) { | ||
| expect(jumpToPastState.future.length).to.be.above(incrementedState.future.length) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More changes to finish #86.