Skip to content

Conversation

@nmay231
Copy link
Collaborator

@nmay231 nmay231 commented Jan 10, 2020

Please check if the PR fulfills these requirements

  • Is this just a doc change? no

  • If no, then check that:

    • The commit message(s) are descriptive of the changes made
    • The PR contains changes that are focused and differs from other PRs
    • Tests for the changes have been added where needed
    • Docs have been added / updated

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Removed the .eslintignore file. I don't think it is necessary anymore since we explicitly list what we lint in the package.json

@nmay231 nmay231 requested a review from omnidan January 10, 2020 11:56
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.674% when pulling fcbd921 on dev/remove-eslintignore into b337ee1 on master.

@omnidan omnidan merged commit e248cb7 into master Jan 10, 2020
@omnidan
Copy link
Owner

omnidan commented Jan 10, 2020

thank you! looks good 👌

@nmay231 nmay231 deleted the dev/remove-eslintignore branch January 11, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants