Refactor and index/limit #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much @davidroeca - great work! Looks good to me, I'll merge it 👌 |
|
released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed undo and redo functions since the jump function handles their cases and I manage all state reassignments using the newHistory function so that standard behavior is handled appropriately and so that non-standard behavior feels more distinct (e.g. the createHistory function and the syncFilters flag).
Also, I added the index/limit mentioned in #162 since it's a trivial add with the refactor. I'd say the next section to focus on is history initialization and config management since both are a bit confusing
Also, add in fix for #171