Make authorization server configurable#9
Merged
dandrews merged 7 commits intoomniauth:masterfrom Nov 4, 2019
hectron:master
Merged
Make authorization server configurable#9dandrews merged 7 commits intoomniauth:masterfrom hectron:master
dandrews merged 7 commits intoomniauth:masterfrom
hectron:master
Conversation
Fix client options
This commit allows users to set a custom authorization server, in the event that they may have more than just one. It also fixes the way that the ID/Access token are decrypted, based on which authorization server it comes from.
Contributor
Author
|
Any thoughts on merging this, @dandrews ? |
Collaborator
|
Thanks @hectron - the PR is much appreciated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I ran into the issue where I have multiple authorization servers in Okta and did not use the
defaultauthorization server.OmniAuth::Strategies::Oktahard codes theuserinfoendpoint to thedefaultauthorization server. Additionally, it tries to use the base URL authorization server to decode the JWT, as well as determine the audience (e.g.http://my-okta-url/oauth2/v1as opposed tohttp://my-okta-url/oauth2/<custom or default>/v1. The default audience isapi://default.)Proposal
Add some configuration to allow us to support more than just the
defaultauthorization server, and also remove any kind of hard-coded endpoints.