Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
=======================================
Coverage 96.79% 96.79%
=======================================
Files 4 4
Lines 312 312
Branches 116 116
=======================================
Hits 302 302
Misses 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes the LDAP attribute-to-info mapping configurable by converting the hardcoded CONFIG constant into a customizable :mapping option. Users can now override the default mapping to customize which LDAP attributes map to the returned auth.info hash.
- Converted
CONFIGconstant tooption :mappingto allow user customization - Updated RBS type signatures to remove the obsolete
CONFIGconstant - Added comprehensive test coverage for custom mapping in both standard and header SSO authentication flows
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/omniauth/strategies/ldap.rb | Replaced hardcoded CONFIG constant with configurable :mapping option and modernized safe navigation syntax |
| spec/omniauth/strategies/ldap_spec.rb | Fixed string literal escaping in filter tests and added test coverage for custom mapping functionality |
| sig/omniauth/strategies/ldap.rbs | Removed obsolete CONFIG constant from type signatures |
| README.md | Added documentation for the new :mapping option and attempted to fix Discord link reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
19d6e4d to
c7c944d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces and closes #45