Skip to content

Symlink downloaded artifacts#97

Merged
manics merged 10 commits intoome:masterfrom
manics:symlink-artifacts
Mar 20, 2017
Merged

Symlink downloaded artifacts#97
manics merged 10 commits intoome:masterfrom
manics:symlink-artifacts

Conversation

@manics
Copy link
Member

@manics manics commented Nov 25, 2016

For example:

  • omego download py behaves as normal
  • omego download py --sym auto symlinks the unzipped download to OMERO.py
  • omego download py --sym /tmp/abc symlinks the unzipped download to /tmp/abc

Closes #60

Changes (since 2017-03-09):

  • the default OMERO-CURRENT sym has been changed to OMERO.server, though omego will warn if the old sym is detected.
  • rebased
  • travis fixed

@joshmoore
Copy link
Member

NB: while we're here, should we go ahead and change OMERO-CURRENT to OMERO.server? (That's what you've been doing elsewhere anyway)

cc: @kennethgillen @sbesson

@sbesson
Copy link
Member

sbesson commented Nov 25, 2016

Assuming our roadmap is 0.5.0, changing the default to OMERO.server makes complete sense to me.

@manics
Copy link
Member Author

manics commented Nov 25, 2016

Do you think that should be a separate PR (since it's clearly a breaking change)?

@manics
Copy link
Member Author

manics commented Nov 25, 2016

Also travis has a new error:

$ psql -c "create user omero with password 'omero';" -U postgres
CREATE ROLE

$ psql -c "create database omero with owner omero;" -U postgres
CREATE DATABASE

$ psql -c "select 1;" -U omero -h localhost omero
 ?column? 
----------
        1
(1 row)

(END)

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

The build has been terminated

@joshmoore
Copy link
Member

Travis issue:

The repository at ome/omego was not found.

Closing & re-opening.

@joshmoore joshmoore closed this Nov 28, 2016
@joshmoore joshmoore reopened this Nov 28, 2016
manics added 3 commits March 10, 2017 10:32
Otherwise you'd need to check whether the symlink is in the current directory or some other directory.
@manics manics force-pushed the symlink-artifacts branch 3 times, most recently from 063841d to 35612bd Compare March 10, 2017 13:34
@manics manics force-pushed the symlink-artifacts branch from aebe125 to 27562cd Compare March 10, 2017 15:34
@manics
Copy link
Member Author

manics commented Mar 13, 2017

Discovered and fixed a bug in the creation of symlinks when the artifact has already been downloaded and unzipped. Also fixed a test that was effectively assert True 😄

@sbesson sbesson modified the milestone: 0.5.0 Mar 20, 2017
@manics manics merged commit 9129c71 into ome:master Mar 20, 2017
@manics manics deleted the symlink-artifacts branch March 20, 2017 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Permit symlinking from download

4 participants