Merged
Conversation
Member
|
NB: while we're here, should we go ahead and change |
Member
|
Assuming our roadmap is |
Member
Author
|
Do you think that should be a separate PR (since it's clearly a breaking change)? |
Member
Author
|
Also travis has a new error: |
Member
|
Travis issue: Closing & re-opening. |
Otherwise you'd need to check whether the symlink is in the current directory or some other directory.
063841d to
35612bd
Compare
aebe125 to
27562cd
Compare
tmpdir.ensure creates a path and returns it instead of testing for it's existence
Member
Author
|
Discovered and fixed a bug in the creation of symlinks when the artifact has already been downloaded and unzipped. Also fixed a test that was effectively |
mtbc
approved these changes
Mar 13, 2017
sbesson
approved these changes
Mar 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example:
omego download pybehaves as normalomego download py --sym autosymlinks the unzipped download toOMERO.pyomego download py --sym /tmp/abcsymlinks the unzipped download to/tmp/abcCloses #60
Changes (since 2017-03-09):
OMERO-CURRENTsym has been changed toOMERO.server, thoughomegowill warn if the old sym is detected.