Conversation
joshmoore
left a comment
joshmoore
left a comment
There was a problem hiding this comment.
Few questions, but the changes generally look fine. It looks, however, as if the build has hung.
.github/workflows/workflow.yml
Outdated
| fail-fast: false | ||
| matrix: | ||
| python-version: | ||
| - '3.6' |
There was a problem hiding this comment.
A side note: python 3.6 is still listed in the docs, but this is something we may want to re-evaluate. See ome/omero-demo-cleanup#6 (comment)
There was a problem hiding this comment.
Ah, I see it got bumped later. 👍
.github/workflows/workflow.yml
Outdated
| uses: actions/setup-java@v1 | ||
| with: | ||
| java-version: 11 | ||
| - name: Install slice2java |
There was a problem hiding this comment.
I again note that some of this would be better refactored either into a re-usable workflow or into a script somewhere.
There was a problem hiding this comment.
yes.If we are okay with the name of the repo I have put in place of re-usable workflows (https://github.com/jburel/action-workflows) I could start refactoring
There was a problem hiding this comment.
ome/action-workflows seems fine. Worst case we have to re-adjust in the future.
There was a problem hiding this comment.
Actually I think that in that case we will need to use composite action e.g. https://github.com/jburel/action-workflows/blob/main/action.yml
So the repository mentioned is not going to work since we will need one repo per composite action i.e. something similar to ansible roles.
| self.branch = 'OMERO-DEV-latest' | ||
| self.ice = '3.6' | ||
|
|
||
| @pytest.mark.skipif(True, reason='URL to be updated') |
There was a problem hiding this comment.
What does "URL to be updated" mean?
There was a problem hiding this comment.
I meant: Change URL since it uses the old ci
| @pytest.mark.slowtest | ||
| @pytest.mark.skipif(True, | ||
| reason='OMERO not supported on Python 3.6') | ||
| @pytest.mark.skipif(True, reason='OMERO not supported on Python 3.6') |
There was a problem hiding this comment.
Does this still hold if you've bumped to Py38?
There was a problem hiding this comment.
I have not re-activated the tests in this PR. I have actually skipped a good number due to URL.
This will be a second body of work
There was a problem hiding this comment.
I have not re-activated the tests in this PR
Fair enough. The comment might just be slightly confusing.
|
The build hangs in travis not GHA related. |
Ok, probably needs to be de-activated, but why isn't your workflow showing up? |
|
This is a limitation of GHA, it will show up when it is merged. |
|
@joshmoore cf. composite action. something like f72fc4a See run https://github.com/jburel/omego/actions/runs/2275975849 |
|
Run with 4260b9a |
| - uses: actions/checkout@v2 | ||
| - name: Install Ice Java and Python binding | ||
| uses: jburel/action-ice@v1 | ||
| uses: ome/action-ice@v1 |
There was a problem hiding this comment.
|
Anyone still have memories of how to disconnect travis?! |
Done. For the record, https://github.com/ome/omego/settings/branches, then |
|
Thanks, guys. Still seems that the workflow isn't running. |
|
It will only be running when it is merged in master. Unfortunately it has to be validated with my account cf. links of actions run |
Not necessarily for this PR but I imagine pushing a stub no-op workflow to |
That's true |
|
@joshmoore @sbesson i applied the suggestion from @sbesson i.e. pushed an empty workflow to master and modified in this PR. |
|
Thanks for slogging through this, @jburel! Very happy to start rolling the actions to other repos. |
|
Leaving you to capture the test re-activation(s) how you see best. |
3 participants
This PR partially re-activates the check via GHA
More clean up to be done
See https://github.com/jburel/omego/actions/runs/2269147023