Merged
Conversation
Member
|
👍 do you want to split the |
Member
Author
|
I can do but i don't think there is any rush to have that in. |
manics
suggested changes
Dec 6, 2018
Member
manics
left a comment
manics
left a comment
There was a problem hiding this comment.
Looks mostly OK, apart from the multi-stage DB upgrade test.
manics
approved these changes
Dec 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
This PR currently uses the wheel for Ubuntu from gitlab.
This will need to be modified before this PR is merged
cc @manics