Skip to content

Simplify install/upgrade commands and db flags#107

Merged
joshmoore merged 7 commits intoome:masterfrom
manics:db-check
Jun 20, 2017
Merged

Simplify install/upgrade commands and db flags#107
joshmoore merged 7 commits intoome:masterfrom
manics:db-check

Conversation

@manics
Copy link
Member

@manics manics commented Jun 15, 2017

Follow on from ome/ansible-role-omero-server#12 (comment)

  • replaces omego upgrade with omego install --upgrade
  • replaces --initdb --upgradedb with a single --managedb
  • adds tests for omero db upgrade -n exit codes

This should be backwards compatible

manics added a commit to manics/ansible-role-omero-server that referenced this pull request Jun 15, 2017
@manics manics mentioned this pull request Jun 15, 2017
8 tasks
@joshmoore
Copy link
Member

A bit of feedback:

  • I think the general deprecation strategy and the fewer options all make sense at the 0.6.x level
  • but I'm worried that the actions are becoming less clear (ignoring the deprecated bits).
  • I wonder if a different name ("server"? "deploy"?) would help clarify,
  • or even if the goal shouldn't be usage as ansible module (omego_install, etc)

Obviously those are pretty big changes. If we need this as 0.6.2 in order to move forward, then no immediate objections from me, but I think we will have to revisit this.

cc: @sbesson

@manics
Copy link
Member Author

manics commented Jun 15, 2017

We could simplify things by getting rid of the managedb flag, so its omego install or omego install --upgrade and any db stuff just happens.

manics added a commit to manics/ansible-role-omero-server that referenced this pull request Jun 16, 2017
@joshmoore
Copy link
Member

👍 for the test. It certainly looks to cover the new setup well. Merging and releasing as 0.6.2, and we'll decide on the breaking changes for 0.7 or 1.0.

@joshmoore joshmoore merged commit abdd852 into ome:master Jun 20, 2017
@joshmoore
Copy link
Member

@manics manics deleted the db-check branch June 20, 2017 09:26
@sbesson sbesson added this to the 0.6.2 milestone Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants