Feature: Add metrics collection for valkey modules metrics #1051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disclaimer: I don't use valkey modules, metrics are collected based on docker image run output and metric types are suggested based on documentation, naming and code. * Add metrics collection for valkey modules metrics * Add tests suite for valkey modules metrics collection * Drop redis-stack (v7.4) modules metrics collection test suite as it reached EOL * Add comments for redis-stack specific metrics * Remove redis-stack / TEST_REDIS_MODULES_URI * Replace TEST_REDIS_MODULES_URI with `TEST_VALKEY8_BUNDLE_URI` in TestSimultaneousMetricsHttpRequests() fix: oliver006#1049 and oliver006#1050
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1051 +/- ##
==========================================
+ Coverage 81.93% 82.17% +0.24%
==========================================
Files 20 20
Lines 3094 3136 +42
==========================================
+ Hits 2535 2577 +42
Misses 443 443
Partials 116 116 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pull Request Test Coverage Report for Build 18570564070Details
💛 - Coveralls |
nantiferov
commented
Oct 16, 2025
| // Valkey v8 metrics | ||
| "bf_bloom_defrag_hits": "bf_bloom_defrag_hits_total", | ||
| "bf_bloom_defrag_misses": "bf_bloom_defrag_misses_total", | ||
| "search_worker_pool_suspend_cnt": "search_worker_pool_suspend_count", |
Contributor
Author
There was a problem hiding this comment.
Afaik according to Prometheus recommendations, _count suffix is valid for counters and some of the metrics has already this suffix.
For ones with _cnt ending, I'm renaming them to _count for consistency.
oliver006
approved these changes
Oct 17, 2025
Owner
oliver006
left a comment
oliver006
left a comment
There was a problem hiding this comment.
This is great, thanks for the quick follow-up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: I don't use valkey modules, metrics are collected based on docker image run output and metric types are suggested based on documentation, naming and code.
TEST_VALKEY8_BUNDLE_URIin TestSimultaneousMetricsHttpRequests()fix: #1049, fix: #1050