Add some more fields. #61
Conversation
|
Please make all of the new fields |
|
|
||
| /// A target platform. | ||
| #[derive(Clone, Serialize, Deserialize, Debug)] | ||
| pub struct Platform(String); |
There was a problem hiding this comment.
should this be #[serde(transparent)]?
There was a problem hiding this comment.
Hm, I don't understand the difference. What does transparent do that the normal newtype struct doesn't do?
There was a problem hiding this comment.
For JSON there's no difference I think, but some data formats may include the name for unit-structs, which is exposed for non-transparent wrappers
There was a problem hiding this comment.
Ah. It also generates less code, which seems nice.
I'm a little confused. Isn't that the default behavior for |
I don't think so. But since you are mentioning it, a test would be great ;) |
|
I've updated with a new test suite. I can split that off into a separate PR, if you'd like. In the past I have missed having a way to test things, so maybe this can establish a way to ensure everything works. Hopefully it's ok? It actually helped exposed a bug in either cargo or cargo_metadata (rust-lang/cargo#6534 — I'm hoping to just fix it in Cargo). |
|
Absolutely wonderful! Thanks |
|
@oli-obk I'd appreciate a release 😉 |
|
ups, done |
3 participants
This is to help assist with stabilizing alternative registries.
Dependency::rename— Stabilized in 1.31.Dependency::registry— Recently added in Add dependencyregistrytocargo metadata. rust-lang/cargo#6500Dependency::target— Add typed as suggested in Expose remaining fields in Dependency #41 (comment). Parsing this is rather complex (see https://github.com/rust-lang/cargo/blob/dcb4360c50574483dc96e8862afcb1e581c7b95c/src/cargo/util/cfg.rs).Package::links— Recently added in Addlinkstocargo metadata. rust-lang/cargo#6480The
registryfield could use a URL type (withurlandurl_serdecrates) if you want it to be more strictly typed (ala #59).