feat: use mutex locks in okta_app_signon_policy_rule#2571
Merged
Conversation
pranav-okta
force-pushed
the
OKTA-1052616-fix-priority
branch
from
fab6a90 to
dae465b
Compare
| return resourceOIEOnlyFeatureError(resources.OktaIDaaSAppSignOnPolicyRule) | ||
| } | ||
|
|
||
| oktaMutexKV.Lock(resources.OktaIDaaSAppSignOnPolicyRule) |
Contributor
There was a problem hiding this comment.
Please record VCR tests for the issue i.e record the test for the configuration that was buggy which your PR fixes.
|
|
||
| ~> **WARNING:** This feature is only available as a part of the Identity Engine. [Contact support](mailto:dev-inquiries@okta.com) for further information. | ||
|
|
||
| ~> **WARNING:** When managing multiple `okta_app_signon_policy_rule` resources with concurrent operations, the Okta API may encounter concurrency issues. While this provider implements internal locking to prevent conflicts within a single Terraform process, you should use explicit `depends_on` references between rules to ensure proper sequencing, especially when managing rule priorities. |
Contributor
There was a problem hiding this comment.
Can we please include this caveat in the PR's description ?
Just in case they don't see the Files Changed.
dhiwakar-okta
previously approved these changes
Nov 24, 2025
Contributor
dhiwakar-okta
left a comment
dhiwakar-okta
left a comment
There was a problem hiding this comment.
Approved with comments.
pranav-okta
force-pushed
the
OKTA-1052616-fix-priority
branch
from
47ae4c3 to
f88e9b8
Compare
pranav-okta
force-pushed
the
OKTA-1052616-fix-priority
branch
from
f88e9b8 to
fd2a192
Compare
Merged
andrew951
pushed a commit
to andrew951/terraform-provider-okta
that referenced
this pull request
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix mirrors the solution in #1248, which addressed the same issue for okta_auth_server_policy_rule. That PR demonstrated that mutex locking at the resource level effectively prevents API concurrency issues while maintaining correct Terraform state management.
When managing multiple
okta_app_signon_policy_ruleresources with concurrent operations, the Okta API may encounter concurrency issues. While this provider implements internal locking to prevent conflicts within a single Terraform process, you should use explicitdepends_onreferences between rules to ensure proper sequencing, especially when managing rule priorities.