fix lucky theme bug

[meizikeai]

User description

Title: fix(theme): add missing newline in lucky theme

Description: This PR fixes a visual bug in themes/lucky/lucky.theme.sh.

The Issue: Currently, the prompt does not start on a new line if the preceding command output lacks a trailing newline (e.g., calling a REST API via curl). This results in the prompt being appended directly to the output, making it difficult to read.

Example of the bug:

# curl --location 'http://127.0.0.1:9997/'
{"code":200,"message":"OK"}root @ f10dd4ccacc0 in ~ [15:22:00]

Changes:

• Adjusted the prompt configuration in lucky.theme.sh to ensure it renders correctly regardless of previous command output.

I would appreciate it if this could be merged into the master branch.

---

PR Type

Bug fix

---

Description

• Add missing newline to lucky theme prompt

• Ensures prompt starts on new line after commands

• Fixes visual bug when output lacks trailing newline

---

Diagram Walkthrough

flowchart LR
  A["Command Output<br/>without newline"] -- "prompt appended<br/>directly" --> B["Bug: unreadable"]
  C["Command Output<br/>without newline"] -- "newline prefix<br/>added" --> D["Fixed: readable prompt"]

Loading

File Walkthrough

	Relevant files
Bug fix	lucky.theme.sh Prepend newline to prompt initialization                                  themes/lucky/lucky.theme.sh Prepend newline character to PS1 variable initialization Ensures prompt renders on new line regardless of previous command output Fixes issue where prompt was appended directly to output lacking trailing newline +1/-1

---

[qodo-free-for-open-source-projects]

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Passed Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

[qodo-free-for-open-source-projects]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Quote variable to prevent word splitting Double-quote the $python_venv variable expansion to prevent word splitting and globbing by the shell. themes/lucky/lucky.theme.sh [17] -PS1='\n'$python_venv +PS1='\n'"$python_venv" Apply / Chat Suggestion importance[1-10]: 7 __ Why: The suggestion correctly identifies a potential bug due to an unquoted variable, which could lead to word splitting, and proposes a fix that aligns with shell scripting best practices.	Medium
More

[PascalKont]

You just added a \n to every print of the prompt, so it will add a newline regardless of the output of the previous command.
So this is not a fix.

---

With your fix, notice the extra new line:

Without your fix:

---

Also, this behavior occurs with other themes as well. So i think, if a fix is developed, it should be implemented in all themes.

minimal:

agnoster: