fix(plugins/nvm): Correctly handle .nvmrc in a parent directory.

[aclemons]

When checking the version in the resolved .nvmrc file found, the
change made in d2163a6 tried to read the file a second time, but did not
use the resolved $nvm_path but rather tried to simply read it from the
current directory. This fails if the file was resolved to a parent
directory.

This change updates the code to reuse the version value which was read
from the file two lines prior.

[akinomyoga]

This file is just a copy of the upstream. I checked the upstream change history again. There seem to have been more changes than I checked previously. I guess I missed the changes in git blame because of the timestamp of nvm-sh/nvm#1569 (which was submitted to nvm-sh/nvm on 2017-06-30 but merged on 2023-12-05).

• 2018-11-06 https://github.com/nvm-sh/nvm/pull/1865/files This introduced the function
• 2019-01-01 https://github.com/nvm-sh/nvm/pull/1971/files
• 2019-03-15 https://github.com/nvm-sh/nvm/pull/2017/files This is supposed to have been applied in d2163a6
• 2019-08-18 https://github.com/nvm-sh/nvm/pull/2086/files This PR
• 2020-06-20 https://github.com/nvm-sh/nvm/pull/2235/files
• 2020-10-06 https://github.com/nvm-sh/nvm/pull/2313/files
• 2021-02-20 https://github.com/nvm-sh/nvm/pull/2442/files
• 2021-09-22 https://github.com/nvm-sh/nvm/pull/2604/files not applicable
• 2021-09-29 https://github.com/nvm-sh/nvm/pull/2605/files This PR (extra commit)
• 2021-11-23 https://github.com/nvm-sh/nvm/pull/2658/files
• 2022-10-08 https://github.com/nvm-sh/nvm/pull/2840/files
• 2023-04-12 https://github.com/nvm-sh/nvm/pull/3082/files not applicable
• 2023-12-05 https://github.com/nvm-sh/nvm/pull/1569/files This PR (extra commit)

[akinomyoga]

I'll check this PR again later.

[akinomyoga]

• 2020-06-20 https://github.com/nvm-sh/nvm/pull/2235/files

I doubt tr ... is needed in the first place. The implementation of find-up should print a valid path, so there is no need to remove anything from the output. Rather, one shouldn't change anything in the path. The original intent of tr could possibly be to remove the newline added by the echo builtin, but in that case, that extra newline is supposed to be removed by the command substitution $(...), so one doesn't need to remove the ending newline anyway.

• 2021-02-20 https://github.com/nvm-sh/nvm/pull/2442/files

I'm not sure if nvm_find_up is really ensured to exist in the user's environment, so I won't pick this up for now.

• 2021-09-29 https://github.com/nvm-sh/nvm/pull/2605/files
• 2023-12-05 https://github.com/nvm-sh/nvm/pull/1569/files

I added changes in 4098fed.

[akinomyoga]

Thanks!