fix: disable test_responses_store#2244
Merged
Merged
Conversation
ashwinb
requested review from
bbrowning,
ehhuang,
hardikjshah,
leseb,
raghotham,
terrytangyuan and
yanxi0830
as code owners
facebook-github-bot
added
the
CLA Signed
raghotham
approved these changes
May 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test depends on llama's tool calling ability. In the CI, we run with a small ollama model.
The fix might be to check for either message or function_call because the model is flaky and we aren't really testing that behavior?