feat: add llama stack rm command#2127
Merged
Merged
Conversation
akoserwal
requested review from
SLR722,
ashwinb,
dineshyv,
dltn,
ehhuang,
hardikjshah,
leseb,
raghotham,
sixianyi0721,
terrytangyuan,
vladimirivic and
yanxi0830
as code owners
facebook-github-bot
added
the
CLA Signed
leseb
requested changes
May 12, 2025
leseb
left a comment
leseb
left a comment
Member
There was a problem hiding this comment.
I’m usually not keen on deleting things from the filesystem. To be as helpful as possible, I think we should start with a stack list command, assuming that makes sense.
leseb
requested changes
May 13, 2025
akoserwal
force-pushed
the
add-flag-rm
branch
2 times, most recently
from
df360b0 to
b971ae5
Compare
Bobbins228
approved these changes
May 16, 2025
Bobbins228
left a comment
Bobbins228
left a comment
Contributor
There was a problem hiding this comment.
Thoroughly tested both the rm and list commands, works great!
/lgtm
leseb
reviewed
May 19, 2025
leseb
left a comment
leseb
left a comment
Member
There was a problem hiding this comment.
Please update the relevant docs.
leseb
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[Provide a short summary of what this PR does and why. Link to relevant issues if applicable.]
#225
Test Plan
[Describe the tests you ran to verify your changes with result summaries. Provide clear instructions so the plan can be easily re-executed.]