Skip to content

Conversation

@LucasLefevre
Copy link
Collaborator

SUBTOTAL should ignore SUBTOTAL values from a spilled formula

A1: "1"
A2: "1"
A3: "=SUBTOTAL(9, A1:A2) + A1:A2"
A5: "=SUBTOTAL(9, A4)"

=> A5 should be zero because the value in A4 comes from a SUBTOTAL formula and it should be ignored

Task: 5261987

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

SUBTOTAL should ignore SUBTOTAL values from a spilled formula

A1: "1"
A2: "1"
A3: "=SUBTOTAL(9, A1:A2) + A1:A2"
A5: "=SUBTOTAL(9, A4)"

=> A5 should be zero because the value in A4 comes from a SUBTOTAL
formula and it should be ignored

Task: 5261987
@robodoo
Copy link
Collaborator

robodoo commented Nov 13, 2025

Pull request status dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants