[IMP] pivot: add tabular form #7386
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
This commit adds a new setting for pivot: whether to use tabular form. In tabular form, each level of row header is displayed in a separate column. Task: 4794334
hokolomopo
force-pushed
the
master-expanded-pivot-row-headers-adrm
branch
from
f539cff to
6836cc8
Compare
LucasLefevre
reviewed
Nov 7, 2025
Comment on lines
+148
to
+150
| const tabularForm = definition.style?.tabularForm ?? DEFAULT_PIVOT_STYLE.tabularForm; | ||
|
|
||
| if (pivotCell.type === "HEADER" && pivotId && pivotCell.domain.length) { | ||
| const definition = getters.getPivotCoreDefinition(pivotId); | ||
| if (!tabularForm && pivotCell.type === "HEADER" && pivotId && pivotCell.domain.length) { |
Collaborator
There was a problem hiding this comment.
The icon is still displayed when it's not in tabular form in the definition, but it is in the PIVOT formula (and nothing works)
Contributor
Author
There was a problem hiding this comment.
Yeah .... I think I'll wait for the pivot style PR before fixing this, in there we should have a strategy to get the actual pivot style for a pivot cell (+ the pivot style will need to be adapted for tabular form)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds a new setting for pivot: whether to use tabular form. In tabular form, each level of row header is displayed in a separate column.
Task: 4794334
review checklist