Skip to content

Conversation

@cortadocodes
Copy link
Collaborator

@cortadocodes cortadocodes commented Feb 3, 2021

Contents

New Features

  • Add ability to upload/download files to/from Google Cloud
  • Add option to upload serialised data to Google Cloud in Analysis.finalise

Minor improvements and fixes

  • Pass GCP project and bucket names to tests from environment

Notes

Quality Checklist

  • New features are fully tested (No matter how much Coverage Karma you have)

@cortadocodes cortadocodes changed the base branch from main to release/0.1.9 February 3, 2021 16:47
@cortadocodes cortadocodes self-assigned this Feb 3, 2021
@cortadocodes cortadocodes changed the title Feature: Aadd cloud file upload Feature: Add cloud file upload Feb 3, 2021
@codecov-io
Copy link

codecov-io commented Feb 3, 2021

Codecov Report

Merging #96 (869a77c) into release/0.1.9 (25da590) will increase coverage by 0.00%.
The diff coverage is 97.22%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release/0.1.9      #96   +/-   ##
==============================================
  Coverage          96.36%   96.36%           
==============================================
  Files                 51       52    +1     
  Lines               1100     1129   +29     
==============================================
+ Hits                1060     1088   +28     
- Misses                40       41    +1     
Impacted Files Coverage Δ
octue/utils/cloud/credentials.py 80.00% <ø> (ø)
octue/resources/analysis.py 97.91% <90.00%> (-2.09%) ⬇️
.../resources/communication/google_pub_sub/service.py 100.00% <100.00%> (ø)
octue/utils/cloud/persistence.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25da590...869a77c. Read the comment docs.

@cortadocodes cortadocodes requested a review from thclark February 3, 2021 21:16
@cortadocodes cortadocodes marked this pull request as ready for review February 3, 2021 21:16
@cortadocodes cortadocodes merged commit 6b48607 into release/0.1.9 Feb 8, 2021
@cortadocodes cortadocodes deleted the feature/add-cloud-file-upload branch February 8, 2021 13:12
@cortadocodes cortadocodes mentioned this pull request Feb 8, 2021
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants