Skip to content

Conversation

@cortadocodes
Copy link
Collaborator

@cortadocodes cortadocodes commented Feb 2, 2021

Contents

Minor fixes and improvements

  • Add ability to delete topic and subscription when a Service has finished serving
  • Facilitate graceful exit for serving Services on KeyboardInterrupt

Testing

  • Test that children can question their own children as part of answering a question
  • Close Ensure test topics and subscriptions are deleted even on test failure #94 - delete topics and subscriptions at the end of each test
  • Remove timeouts from tests and replace with thread executor shutdown upon test pass, meaning that tests that connect to Google Pub/Sub won't fail because the connection is slower than expected

@cortadocodes cortadocodes requested a review from thclark February 2, 2021 15:04
@cortadocodes cortadocodes self-assigned this Feb 2, 2021
@cortadocodes cortadocodes changed the title Test: Ensure children can question its own children as part of answering a question Test: Ensure children can question their own children as part of answering a question Feb 2, 2021
@cortadocodes cortadocodes removed the request for review from thclark February 2, 2021 16:20
@codecov-io
Copy link

codecov-io commented Feb 2, 2021

Codecov Report

Merging #93 (a5514cc) into release/0.1.9 (25da590) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release/0.1.9      #93      +/-   ##
=================================================
+ Coverage          96.36%   96.37%   +0.01%     
=================================================
  Files                 51       51              
  Lines               1100     1104       +4     
=================================================
+ Hits                1060     1064       +4     
  Misses                40       40              
Impacted Files Coverage Δ
octue/cli.py 97.29% <100.00%> (+0.03%) ⬆️
.../resources/communication/google_pub_sub/service.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25da590...a5514cc. Read the comment docs.

@cortadocodes cortadocodes requested a review from thclark February 3, 2021 12:00
@cortadocodes cortadocodes changed the title Test: Ensure children can question their own children as part of answering a question Fix: Ensure GCP tests don't fail on slow connection; add missing Service test cases Feb 3, 2021
@cortadocodes cortadocodes merged commit ccafaef into release/0.1.9 Feb 8, 2021
@cortadocodes cortadocodes deleted the fix/allow-children-to-contact-more-than-one-child branch February 8, 2021 13:19
@cortadocodes cortadocodes mentioned this pull request Feb 8, 2021
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants