Skip to content

Conversation

@cortadocodes
Copy link
Collaborator

@cortadocodes cortadocodes commented Jan 13, 2021

Minor fixes and improvements

  • Add a package-level logger
  • Add --show-twined-logs option to CLI so developers can also see logs from the SDK
  • Move handler argument from Runner.run to Runner constructor
  • Make log format more human readable

Quality Checklist

  • New features are fully tested (No matter how much Coverage Karma you have)

@cortadocodes cortadocodes changed the base branch from main to release/0.1.8 January 13, 2021 12:13
@cortadocodes cortadocodes self-assigned this Jan 13, 2021
@cortadocodes cortadocodes requested a review from thclark January 13, 2021 12:48
@codecov-io
Copy link

codecov-io commented Jan 13, 2021

Codecov Report

Merging #78 (86788c8) into release/0.1.8 (b273b5b) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release/0.1.8      #78      +/-   ##
=================================================
+ Coverage          96.30%   96.34%   +0.04%     
=================================================
  Files                 40       40              
  Lines                839      849      +10     
=================================================
+ Hits                 808      818      +10     
  Misses                31       31              
Impacted Files Coverage Δ
octue/__init__.py 100.00% <100.00%> (ø)
octue/cli.py 95.45% <100.00%> (+0.21%) ⬆️
octue/logging_handlers.py 100.00% <100.00%> (ø)
octue/runner.py 92.00% <100.00%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b273b5b...86788c8. Read the comment docs.

@cortadocodes cortadocodes marked this pull request as ready for review January 13, 2021 17:23
@cortadocodes cortadocodes merged commit 4392c7d into release/0.1.8 Jan 13, 2021
@cortadocodes cortadocodes deleted the feature/add-option-to-handle-developer-logs-separately branch January 13, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants