Skip to content

Conversation

@cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented Jul 15, 2024

Contents (#668)

IMPORTANT: There are 2 breaking changes.

Enhancements

  • 💥 BREAKING CHANGE: Update ChildEmulator to use EventReplayer, support schema-compliant events and attributes, and support heartbeats and delivery acknowledgement events. This significantly simplifies the emulator
  • 💥 BREAKING CHANGE: Remove ChildEmulator.from_file
  • Download manifest datasets to same directory by default

Refactoring

  • Move ServicePatcher into its own module

Upgrade instructions

💥 Update `ChildEmulator` to use `EventReplayer` and full events

Give events (including attributes) that satisfy the service communication schema to child emulators.

💥 Remove `ChildEmulator.from_file`

Load the JSON file separately and pass the events into the ChildEmulator constructor.

BREAKING CHANGE: Give events (including attributes) that satisfy the service communication schema to child emulators.

skipci
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.55%. Comparing base (330ea82) to head (ed77f40).
Report is 243 commits behind head on main.

Files Patch % Lines
octue/cloud/emulators/child.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #668      +/-   ##
==========================================
- Coverage   94.62%   94.55%   -0.07%     
==========================================
  Files          82       83       +1     
  Lines        3552     3546       -6     
==========================================
- Hits         3361     3353       -8     
- Misses        191      193       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cortadocodes cortadocodes self-assigned this Jul 16, 2024
@cortadocodes cortadocodes merged commit b3cfa00 into main Jul 16, 2024
@cortadocodes cortadocodes deleted the improve-manifest-download branch July 16, 2024 15:24
@cortadocodes cortadocodes changed the title Download manifest dataset to same tempdir by default Update child emulator and improve manifest dataset download Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment