Skip to content

Conversation

@cortadocodes
Copy link
Collaborator

@cortadocodes cortadocodes commented Jan 4, 2021

Contents

New Features

Minor fixes and improvements

  • Raise a more helpful error message if trying to filter by a non-existent attribute of an item in a filter container

Quality Checklist

  • New features are fully tested (No matter how much Coverage Karma you have)

Comments

  • I don't think there's any need for a yield method as you can already yield from both a set and a list and they also already exist in memory so there's no benefit to returning a generator from them. Let me know if I've got the wrong end of the stick here

@cortadocodes cortadocodes changed the base branch from main to release/0.1.7 January 4, 2021 14:53
@cortadocodes cortadocodes marked this pull request as ready for review January 4, 2021 15:14
@cortadocodes cortadocodes requested a review from thclark January 4, 2021 15:15
@cortadocodes cortadocodes self-assigned this Jan 4, 2021
@cortadocodes cortadocodes merged commit 9a036ed into release/0.1.7 Jan 5, 2021
@cortadocodes cortadocodes deleted the feature/add-extra-methods-to-filter-containers branch January 5, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

order_by filtering for Dataset files

2 participants