Skip to content

Release/0.1.6 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thclark merged 30 commits into from
Dec 18, 2020
Merged

Release/0.1.6 #51

thclark merged 30 commits into from
Dec 18, 2020

Conversation

@cortadocodes
Copy link
Collaborator

@cortadocodes cortadocodes commented Dec 18, 2020 •
edited by thclark
Loading

Contents

New Features

Minor fixes and improvements

Quality Checklist

  • New features are fully tested (No matter how much Coverage Karma you have)

Coverage Karma

  • If your PR decreases test coverage, do you feel you have built enough Coverage Karma* to justify it?

@cortadocodes
WIP: Experiment with github workflows
1694d7b
@cortadocodes
FIX: Fix step name
4063a28
@cortadocodes
IMP: Add script to check for branch/setup version consistency
49f01ff
@cortadocodes
WIP: Add check to find out current working directory
a2d0a52
@cortadocodes
IMP: Run version checking script in check
9675891
@cortadocodes
IMP: Add print statements for reviewing check on GitHub
b3b12ad
@cortadocodes
REV: Remove test check
e5b3296
@cortadocodes
FIX: Trigger check on pull request; remove redundant code
ec3647f
@cortadocodes
REF: Simplify check logic
d01a767
@cortadocodes
FIX: Change trigger back to push
2affae9
@cortadocodes
CLN: Remove excess code
8dbbdd3
@cortadocodes
FIX: Use more robust branch name command
bbde4f7
@cortadocodes
FIX: Change back to push trigger again
f17fead
@cortadocodes
REF: Use custom exception if branch is not a release branch
c63d678
@cortadocodes
REF: Split version check into smaller functions
c258f35
@cortadocodes
DOC: Add docstring
c58181e
@cortadocodes
FIX: Handle branch names in invalid format
b588358
@cortadocodes
REF: Rename workflow file
f780583
@cortadocodes
MRG: Merge pull request #42 from octue/devops/check-version-consistency
52a72b3 
Devops: Add version consistency check
@cortadocodes
CHO: Bump version number
f41b832
@cortadocodes
FIX: Prevent imaginary attributes being retrieved from Analysis
ec0fa8b
@cortadocodes
TST: Test non-existent Analysis attributes can't be retrieved
965485c
@cortadocodes
REF: Use setattr rather than __setattr__
f121ef5
@cortadocodes
FIX: Return manifest from Runner._update_manifest_path
6050093
@cortadocodes
TST: Test output manifest of analysis is not None
8db7f24
@cortadocodes
TST: Remove redundant test
1fe6512
@cortadocodes
DOC: Add link to issue in test description
216e1e1
@cortadocodes
CLN: Use unittest assertion method
79690b1
@cortadocodes
MRG: Merge pull request #48 from octue/fix/empty-analysis-attributes
4879ee3 
Prevent imaginary/empty attributes being retrieved from Analysis
@cortadocodes cortadocodes marked this pull request as ready for review December 18, 2020 12:49
@cortadocodes cortadocodes requested a review from thclark December 18, 2020 12:49
@cortadocodes cortadocodes self-assigned this Dec 18, 2020
@thclark thclark merged commit 0dd42ec into main Dec 18, 2020
@thclark thclark deleted the release/0.1.6 branch December 18, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thclark thclark Awaiting requested review from thclark

Assignees

@cortadocodes cortadocodes

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Analysis attributes are None when they shouldn't be Github Action Version Check

3 participants

@cortadocodes @thclark