Skip to content

fix: add App to the type property in the ping event, add workflow_job to App events, merge_commit_sha is not always null for pull_request.opened event #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wolfy1339 merged 5 commits into from
Jul 7, 2022
Merged

fix: add App to the type property in the ping event, add workflow_job to App events, merge_commit_sha is not always null for pull_request.opened event #660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
54b648d
fix: add `App` to the `type` property in the `ping` event
wolfy1339 Jul 7, 2022
bb66917
fix: add `workflow_job` to `App` events
wolfy1339 Jul 7, 2022
c02ba35
build: generate types
wolfy1339 Jul 7, 2022
6ab9871
fix: `merge_commit_sha` is not always `null` for `pull_request.opened…
wolfy1339 Jul 7, 2022
65a64ba
style: run prettier
wolfy1339 Jul 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion payload-schemas/api.github.com/common/app.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,8 @@
"team_add",
"watch",
"workflow_dispatch",
"workflow_run"
"workflow_run",
"workflow_job"
]
}
}
Expand Down
5 changes: 4 additions & 1 deletion payload-schemas/api.github.com/ping/event.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,10 @@
"deliveries_url"
],
"properties": {
"type": { "type": "string", "enum": ["Repository", "Organization"] },
"type": {
"type": "string",
"enum": ["Repository", "Organization", "App"]
},
"id": { "type": "integer" },
"name": { "type": "string" },
"active": { "type": "boolean" },
Expand Down
2 changes: 0 additions & 2 deletions payload-schemas/api.github.com/pull_request/opened.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,13 @@
"state",
"closed_at",
"merged_at",
"merge_commit_sha",
"active_lock_reason",
"merged_by"
],
"properties": {
"state": { "type": "string", "enum": ["open"] },
"closed_at": { "type": "null" },
"merged_at": { "type": "null" },
"merge_commit_sha": { "type": "null" },
"active_lock_reason": { "type": "null" },
"merged_by": { "type": "null" }
},
Expand Down
4 changes: 2 additions & 2 deletions payload-types/schema.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -943,6 +943,7 @@ export interface App {
| "watch"
| "workflow_dispatch"
| "workflow_run"
| "workflow_job"
)[];
}
export interface CheckRunCreatedEvent {
Expand Down Expand Up @@ -4073,7 +4074,7 @@ export interface PingEvent {
* The [webhook configuration](https://docs.github.com/en/rest/reference/repos#get-a-repository-webhook).
*/
hook: {
type: "Repository" | "Organization";
type: "Repository" | "Organization" | "App";
id: number;
name: string;
active: boolean;
Expand Down Expand Up @@ -4680,7 +4681,6 @@ export interface PullRequestOpenedEvent {
state: "open";
closed_at: null;
merged_at: null;
merge_commit_sha: null;
active_lock_reason: null;
merged_by: null;
};
Expand Down