-
Notifications
You must be signed in to change notification settings - Fork 40
Support issue typed and untyped events #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
|
Sorry, this was linked to an internal issue in our org and GitHub got a little overeager to close this. |
|
@JamieMagee because I inadvertantly had an internal PR linked to this one, merging that PR closed this one. That also moved this PR to the Done column in the Octokit Active project board. Would it be possible to get it manually moved back to the Triage status? I don't want to see this PR completely ignored because of that screwup. |
|
@DavidBoike are you able to rebase this PR on top of current |
|
@JamieMagee I rebased |
Head branch was pushed to by a user without write access
|
So @JamieMagee I rebased, then you approved, but in the time it took for CI to run, the branch was no longer up-to-date with main, and now CI won't run until approved again. |
Before the change?
typedoruntypedwould fail to deserialize.After the change?
typedoruntypedwill deserialize correctly, with the type being added/removed available in the root-levelTypeproperty, as well as the current type of the issue as a property of the issue.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!