Skip to content

Conversation

@DavidBoike
Copy link
Contributor

@DavidBoike DavidBoike commented Jun 11, 2025


Before the change?

  • Issue events with action typed or untyped would fail to deserialize.

After the change?

  • Issue events with action typed or untyped will deserialize correctly, with the type being added/removed available in the root-level Type property, as well as the current type of the issue as a property of the issue.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Did not find any docs specifically for issue event subtypes

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@github-actions
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@DavidBoike
Copy link
Contributor Author

Sorry, this was linked to an internal issue in our org and GitHub got a little overeager to close this.

@DavidBoike
Copy link
Contributor Author

@JamieMagee because I inadvertantly had an internal PR linked to this one, merging that PR closed this one. That also moved this PR to the Done column in the Octokit Active project board. Would it be possible to get it manually moved back to the Triage status? I don't want to see this PR completely ignored because of that screwup.

@JamieMagee JamieMagee moved this from ✅ Done to 🆕 Triage in 🧰 Octokit Active Jun 13, 2025
@JamieMagee JamieMagee enabled auto-merge (squash) June 26, 2025 05:13
@JamieMagee JamieMagee disabled auto-merge June 26, 2025 05:18
@JamieMagee
Copy link
Member

@DavidBoike are you able to rebase this PR on top of current main so I can merge it? Or check "Maintainers are allowed to edit this pull request." so I can do it myself.

@DavidBoike
Copy link
Contributor Author

@JamieMagee I rebased

@JamieMagee JamieMagee enabled auto-merge (squash) June 26, 2025 14:47
auto-merge was automatically disabled June 26, 2025 15:25

Head branch was pushed to by a user without write access

@DavidBoike
Copy link
Contributor Author

So @JamieMagee I rebased, then you approved, but in the time it took for CI to run, the branch was no longer up-to-date with main, and now CI won't run until approved again.

@JamieMagee JamieMagee enabled auto-merge (squash) June 26, 2025 15:37
@JamieMagee JamieMagee merged commit 6c3096d into octokit:main Jun 26, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from 🆕 Triage to ✅ Done in 🧰 Octokit Active Jun 26, 2025
@DavidBoike DavidBoike deleted the action-typed branch June 26, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

[BUG]: IssuesEvent deserialization fails when action=typed

2 participants