Skip to content

Conversation

@PromoFaux
Copy link
Contributor

Resolves #679


Before the change?

  • Support for this event does not exist

After the change?

  • Support for this event exists...

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@github-actions
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@PromoFaux
Copy link
Contributor Author

There are a couple of enums introduced here that could potentially be re-used in other event types - but that is probably for a separate PR if at all :)

@PromoFaux
Copy link
Contributor Author

PromoFaux commented Apr 25, 2025

@JamieMagee - Am I right in suspecting that this repo is unmaintained?

I see that https://github.com/octokit/dotnet-sdk exists - but have not looked at it too deeply yet - is it meant to replace this one?

(Edit: No pressure to review or respond!)

@PromoFaux PromoFaux force-pushed the new/repository_advisory branch from af5e875 to cbf3d0b Compare April 25, 2025 22:13
@JamieMagee
Copy link
Member

@PromoFaux apologies for the lack of response here. I lost some permissions in the Octokit org recently, and haven't had a chance to request them back. Until then, I'm not able to merge any PRs or create any releases.

https://github.com/octokit/dotnet-sdk isn't meant to be a replacement for this project, but a replacement for https://github.com/octokit/octokit.net. dotnet-sdk is an experimental SDK automatically generated from https://github.com/github/rest-api-description, whereas octokit.net (and this repository) are manually generated.

@PromoFaux
Copy link
Contributor Author

No worries, I decided to build locally and include the DLLs directly in my project for the time being (hence the force push after spotting an egregious spelling error 😏) so it's working for my purposes for the time being!

Ah OK, cool - I wont look at that in any further detail then, I only need to process webhooks, this one just happened to be missing.

🤞 for you getting permissions back :)

@nickfloyd nickfloyd moved this from 🆕 Triage to 👀 In review in 🧰 Octokit Active Jun 3, 2025
@JamieMagee JamieMagee force-pushed the new/repository_advisory branch from cbf3d0b to 7db68a6 Compare June 26, 2025 05:01
@JamieMagee JamieMagee enabled auto-merge (squash) June 26, 2025 05:12
@JamieMagee JamieMagee merged commit bab0a9c into octokit:main Jun 26, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in 🧰 Octokit Active Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

[FEAT]: Add Support for repository_advisory to WebhookEventProcessor

2 participants