Skip to content

Use DateTimeOffset everywhere instead of string #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Use DateTimeOffset everywhere instead of string #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21cfc0d
Use `DateTimeOffset` everywhere instead of `string`
JamieMagee Jul 2, 2024
2a3b683
Merge branch 'main' into datetimeoffset-everywhere
JamieMagee Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Octokit.Webhooks/Models/WorkflowJobEvent/WorkflowJob.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ public sealed record WorkflowJob
public string? RunnerGroupName { get; init; }

[JsonPropertyName("started_at")]
public string StartedAt { get; init; } = null!;
[JsonConverter(typeof(DateTimeOffsetConverter))]
public DateTimeOffset StartedAt { get; init; }

[JsonPropertyName("completed_at")]
public string? CompletedAt { get; init; }
Expand All @@ -72,5 +73,6 @@ public sealed record WorkflowJob
public string? HeadBranch { get; init; }

[JsonPropertyName("created_at")]
public string CreatedAt { get; init; } = null!;
[JsonConverter(typeof(DateTimeOffsetConverter))]
public DateTimeOffset CreatedAt { get; init; }
}
3 changes: 2 additions & 1 deletion src/Octokit.Webhooks/Models/WorkflowJobEvent/WorkflowJobStep.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ public sealed record WorkflowJobStep
public long Number { get; init; }

[JsonPropertyName("started_at")]
public string StartedAt { get; init; } = null!;
[JsonConverter(typeof(DateTimeOffsetConverter))]
public DateTimeOffset StartedAt { get; init; }

[JsonPropertyName("completed_at")]
[JsonConverter(typeof(NullableDateTimeOffsetConverter))]
Expand Down