Skip to content

Conversation

@renardguill
Copy link
Contributor

@renardguill renardguill commented Feb 29, 2024

Resolves #462
Resolves #460


Before the change?

  • The value of Nuget PackageType is nuget (in lowercase)
  • The type of NugetMetatada property of PackageVersion is IDictionary<string, dynamic>?

After the change?

  • The value of Nuget PackageType is now NUGET (in uppercase) according to the payload sent by GitHub Webhooks.
  • The type of NugetMetatada property of PackageVersion is now IEnumerable<PackageVersionNugetMetadata>? according to the paylod sent by GitHub Webhooks and according to the GitHub Webhooks Docs
  • Added PackageVersionNugetMetadata type for better binding nuget_metadata field of webhook according to the paylod sent by GitHub Webhooks and according to the GitHub Webhooks Docs

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@github-actions
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

Copy link
Member

@JamieMagee JamieMagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll cut a release shortly

@JamieMagee JamieMagee enabled auto-merge (squash) February 29, 2024 22:58
@JamieMagee JamieMagee merged commit 18d2b70 into octokit:main Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

2 participants