Skip to content

Conversation

@G-Rath
Copy link
Member

@G-Rath G-Rath commented Jun 2, 2023

#430 upgraded the Node version to 18, which was breaking - this has since been reverted to 16 via #432 but that is still a breaking change.


Behavior

Before the change?

  • Able to install a package using @ocktokit/plugin-retry with Node 14.

After the change?

  • Unable to install a package using @ocktokit/plugin-retry with Node 14 because it requires Node 16.

Other information

n/a


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@G-Rath G-Rath added the Type: Bug Something isn't working as documented label Jun 2, 2023
@G-Rath G-Rath mentioned this pull request Jun 2, 2023
5 tasks
@G-Rath G-Rath requested review from kfcampbell and wolfy1339 June 2, 2023 21:03
@G-Rath G-Rath enabled auto-merge (squash) June 2, 2023 21:04
@G-Rath G-Rath merged commit 554848c into main Jun 2, 2023
@G-Rath G-Rath deleted the G-Rath-patch-1 branch June 2, 2023 21:04
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

🎉 This PR is included in version 4.1.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Type: Bug Something isn't working as documented

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants