Add optional cancellation token for oauth client#2988
Merged
nickfloyd merged 1 commit intooctokit:mainfrom Jan 3, 2025
Merged
Conversation
This was referenced Jan 24, 2026
This was referenced Feb 5, 2026
This was referenced Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did not make an issue, but there is already multiples PR for other parts of the codebase so I guess this is fine?
Before the change?
We could never cancel login requests (especially device flow requests, which waits for the user to do something in a browser window).
After the change?
We can now cancel such requests.
Pull request checklist
Does this introduce a breaking change?