feat: Implement dependency review and dependency submission APIs#2932
feat: Implement dependency review and dependency submission APIs#2932nickfloyd merged 1 commit intooctokit:mainfrom
Conversation
|
Hey @awedist Thank you for the changes here ❤️ . The SPDX format and the rigidity of how serialization has been implemented will make things a bit more challenging here. We'll need to look to see if the model properties can be annotated to cover the SBOM APIs - I'm pretty sure we could implement a custom naming strategy for the serializer to be able to use or add serializer options. We'd most likely have to modify the implementation in SimpleJson.cs. I'll approve and merge this in as is and we can revisit the other API once we've taken some time to look. |
|
Hi all. I am using Octokit.net in a project atm, great job all by the way :) . Using Newtonsoft ( JsonConvert.DeserializeObject(sbomJson) ) produces a correct deserialization. |
Relates to #2825
Before the change?
Octokit did not support the Dependency Graph APIs.
After the change?
I could not implement the SBOM functionality because the SBOM GitHub API provides a JSON where the keys are in camel case.
If there is a way to configure the deserializer to accept camel case, please let me know.
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!