Skip to content

feat: Add 'Pending' member to WorkflowJobStatus enum#2885

Merged
nickfloyd merged 1 commit intooctokit:mainfrom
redoz:add-pending-to-workflowjobstatus
Feb 15, 2024
Merged

feat: Add 'Pending' member to WorkflowJobStatus enum#2885
nickfloyd merged 1 commit intooctokit:mainfrom
redoz:add-pending-to-workflowjobstatus

Conversation

@redoz
Copy link
Contributor

@redoz redoz commented Feb 14, 2024

Resolves #2882


Before the change?

  • The 'pending' value on the WorkflowJobStep.Status would not deserialize properly.

After the change?

  • The 'pending' value on the WorkflowJobStep.Status should deserialize properly.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

I didn't see any tests/docs relating to this enum, so I didn't create any for this PR, let me know if I missed something and should add them.

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@nickfloyd nickfloyd added the Type: Feature New feature or request label Feb 15, 2024
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @redoz thanks for the contributions here! ❤️ Looks like we're missing quite a few here (docs, .NET generated SDK)

@nickfloyd nickfloyd changed the title Add 'Pending' member to WorkflowJobStatus enum feat: Add 'Pending' member to WorkflowJobStatus enum Feb 15, 2024
@nickfloyd nickfloyd merged commit e4af6f9 into octokit:main Feb 15, 2024
@redoz redoz deleted the add-pending-to-workflowjobstatus branch February 15, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Feature New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[BUG]: WorkflowJobStatus enum does not contain "pending" value.

2 participants